Bug 90890 - [CMAKE] Add missing feature macros
Summary: [CMAKE] Add missing feature macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-10 09:58 PDT by Gyuyoung Kim
Modified: 2012-07-10 15:54 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.55 KB, patch)
2012-07-10 10:02 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-07-10 09:58:43 PDT 
ENABLE_CSS_EXCLUSIONS, ENABLE_CSS_REGIONS, ENABLE_TEXT_AUTOSIZING macros haven't defined in cmake feature list.

There is warning message during the build time.

CMake Warning:
  Manually-specified variables were not used by the project:

    ENABLE_CSS_EXCLUSIONS
    ENABLE_CSS_REGIONS
    ENABLE_TEXT_AUTOSIZING
Comment 1 Gyuyoung Kim 2012-07-10 10:02:09 PDT 
Created attachment 151474 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-07-10 11:35:34 PDT 
Comment on attachment 151474 [details]
Patch

Looks good.
Comment 3 Eric Seidel (no email) 2012-07-10 14:35:04 PDT 
Comment on attachment 151474 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-07-10 15:54:15 PDT 
Comment on attachment 151474 [details]
Patch

Clearing flags on attachment: 151474

Committed r122274: <http://trac.webkit.org/changeset/122274>
Comment 5 WebKit Review Bot 2012-07-10 15:54:20 PDT 
All reviewed patches have been landed.  Closing bug.