Bug 90752 – [Platform-Mac] Derive LocaleMac.{cpp,h} and LocalizedDateMac.cpp from LocaleWin

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

For re-factoring LocalizeDate for Mac. I introduce following files:
* LocaleMac.h <= copy of LocaleWin.h
* LocaleMac.mm <= copy of LocalizedDateMac.mm
* LocalizedDateMac.cpp <= new file. Wrapper of LocaleMac.

Correction:

For re-factoring LocalizeDate for Mac. I introduce following files:
* LocaleMac.h <= copy of LocaleWin.h
* LocaleMac.mm <= copy of LocalizedDateMac.mm
* LocalizedDateMac.cpp <= copy of LocalizedDateWin.cpp

Created attachment 151187 [details]
Patch 1

Comment on attachment 151187 [details]
Patch 1

Could you review this patch?
Thanks in advance.

Note: I'll do "svn copy" rather than commiting this patch as is for keeping history on copied files.

[WebKit Review Bot]

Attachment 151187 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/text/mac/LocaleMac.cpp:32:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/text/mac/LocaleMac.cpp:47:  Declaration has space between type name and * in NSDateFormatter *formatter  [whitespace/declaration] [3]
Source/WebCore/platform/text/mac/LocaleMac.cpp:60:  Declaration has space between type name and * in NSDate *date  [whitespace/declaration] [3]
Source/WebCore/platform/text/mac/LocaleMac.cpp:63:  Extra space before [  [whitespace/braces] [5]
Source/WebCore/platform/text/mac/LocaleMac.cpp:160:  Declaration has space between type name and * in NSArray *array  [whitespace/declaration] [3]
Source/WebCore/platform/text/mac/LocaleMac.cpp:178:  Declaration has space between type name and * in NSArray *array  [whitespace/declaration] [3]
Source/WebCore/platform/text/mac/LocaleMac.cpp:197:  Extra space before [  [whitespace/braces] [5]
Source/WebCore/platform/text/mac/LocaleMac.h:31:  #ifndef header guard has wrong style, please use: LocaleMac_h  [build/header_guard] [5]
Total errors found: 8 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kent Tamura]

Comment on attachment 151187 [details]
Patch 1

ok

Landed:
http://trac.webkit.org/changeset/122091