Bug 90752 - [Platform-Mac] Derive LocaleMac.{cpp,h} and LocalizedDateMac.cpp from LocaleWin
Summary: [Platform-Mac] Derive LocaleMac.{cpp,h} and LocalizedDateMac.cpp from LocaleWin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 90248
  Show dependency treegraph
 
Reported: 2012-07-08 22:37 PDT by yosin
Modified: 2012-07-08 23:55 PDT (History)
2 users (show)

See Also:


Attachments
Patch 1 (16.55 KB, patch)
2012-07-08 22:52 PDT, yosin
tkent: review+
tkent: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-07-08 22:37:26 PDT
For re-factoring LocalizeDate for Mac. I introduce following files:
* LocaleMac.h <= copy of LocaleWin.h
* LocaleMac.mm <= copy of LocalizedDateMac.mm
* LocalizedDateMac.cpp <= new file. Wrapper of LocaleMac.
Comment 1 yosin 2012-07-08 22:43:50 PDT
Correction:

For re-factoring LocalizeDate for Mac. I introduce following files:
* LocaleMac.h <= copy of LocaleWin.h
* LocaleMac.mm <= copy of LocalizedDateMac.mm
* LocalizedDateMac.cpp <= copy of LocalizedDateWin.cpp
Comment 2 yosin 2012-07-08 22:52:28 PDT
Created attachment 151187 [details]
Patch 1
Comment 3 yosin 2012-07-08 22:53:48 PDT
Comment on attachment 151187 [details]
Patch 1

Could you review this patch?
Thanks in advance.

Note: I'll do "svn copy" rather than commiting this patch as is for keeping history on copied files.
Comment 4 WebKit Review Bot 2012-07-08 22:56:12 PDT
Attachment 151187 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/text/mac/LocaleMac.cpp:32:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/text/mac/LocaleMac.cpp:47:  Declaration has space between type name and * in NSDateFormatter *formatter  [whitespace/declaration] [3]
Source/WebCore/platform/text/mac/LocaleMac.cpp:60:  Declaration has space between type name and * in NSDate *date  [whitespace/declaration] [3]
Source/WebCore/platform/text/mac/LocaleMac.cpp:63:  Extra space before [  [whitespace/braces] [5]
Source/WebCore/platform/text/mac/LocaleMac.cpp:160:  Declaration has space between type name and * in NSArray *array  [whitespace/declaration] [3]
Source/WebCore/platform/text/mac/LocaleMac.cpp:178:  Declaration has space between type name and * in NSArray *array  [whitespace/declaration] [3]
Source/WebCore/platform/text/mac/LocaleMac.cpp:197:  Extra space before [  [whitespace/braces] [5]
Source/WebCore/platform/text/mac/LocaleMac.h:31:  #ifndef header guard has wrong style, please use: LocaleMac_h  [build/header_guard] [5]
Total errors found: 8 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Kent Tamura 2012-07-08 23:05:48 PDT
Comment on attachment 151187 [details]
Patch 1

ok
Comment 6 yosin 2012-07-08 23:55:15 PDT
Landed:
http://trac.webkit.org/changeset/122091