Bug 90500 - nrwt: fix mock port
Summary: nrwt: fix mock port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-03 15:14 PDT by Dirk Pranke
Modified: 2012-07-03 16:53 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.69 KB, patch)
2012-07-03 15:16 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
add in chromium_android fix (12.53 KB, patch)
2012-07-03 15:26 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-07-03 15:14:27 PDT
nrwt: fix mock port
Comment 1 Dirk Pranke 2012-07-03 15:16:23 PDT
Created attachment 150676 [details]
Patch
Comment 2 Dirk Pranke 2012-07-03 15:26:51 PDT
Created attachment 150679 [details]
add in chromium_android fix
Comment 3 Ojan Vafai 2012-07-03 16:00:18 PDT
Comment on attachment 150679 [details]
add in chromium_android fix

Do we still have bots that run test_shell for running layout tests?
Comment 4 Dirk Pranke 2012-07-03 16:43:49 PDT
(In reply to comment #3)
> (From update of attachment 150679 [details])
> Do we still have bots that run test_shell for running layout tests?

No, but the android port still uses it; until they finish upstreaming and can remove the code that still uses test_shell it doesn't hurt to leave this around. See bug 88542 and bug 88478.
Comment 5 Dirk Pranke 2012-07-03 16:53:51 PDT
Committed r121812: <http://trac.webkit.org/changeset/121812>