Bug 90256 - Remove still more BUILDING_ON_LEOPARD branches now that no port supports leopard
Summary: Remove still more BUILDING_ON_LEOPARD branches now that no port supports leopard
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 90253
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-29 00:44 PDT by Eric Seidel (no email)
Modified: 2013-05-14 13:42 PDT (History)
9 users (show)

See Also:


Attachments
Patch (28.40 KB, patch)
2012-06-29 00:44 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-06-29 00:44:06 PDT
Remove still more BUILDING_ON_LEOPARD branches now that no port supports leopard
Comment 1 Eric Seidel (no email) 2012-06-29 00:44:32 PDT
Created attachment 150104 [details]
Patch
Comment 2 Ryosuke Niwa 2012-06-29 00:59:12 PDT
Comment on attachment 150104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150104&action=review

> Source/WebCore/ChangeLog:3
>  2012-06-29  Eric Seidel  <eric@webkit.org>
>  
> +        Remove still more BUILDING_ON_LEOPARD branches now that no port supports leopard

This change log is also messed up.
Comment 3 Eric Seidel (no email) 2012-06-29 01:11:00 PDT
Comment on attachment 150104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150104&action=review

>> Source/WebCore/ChangeLog:3
>> +        Remove still more BUILDING_ON_LEOPARD branches now that no port supports leopard
> 
> This change log is also messed up.

Our scripts are smart enough to know how to fix it.  Hence the green EWS bubbles.
Comment 4 WebKit Review Bot 2012-06-29 03:44:26 PDT
Comment on attachment 150104 [details]
Patch

Clearing flags on attachment: 150104

Committed r121547: <http://trac.webkit.org/changeset/121547>
Comment 5 WebKit Review Bot 2012-06-29 03:44:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Tony Chang 2012-06-29 11:14:55 PDT
Reverted r121547 for reason:

Breaks Chromium Mac build

Committed r121575: <http://trac.webkit.org/changeset/121575>
Comment 7 Tobias Netzel 2013-05-14 13:42:23 PDT
This is invalid now that r147447, r147525, r147710 and r149922 have landed.