Bug 90199 - Improve compositing logging output
Summary: Improve compositing logging output
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-28 13:10 PDT by Simon Fraser (smfr)
Modified: 2012-06-28 13:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (15.25 KB, patch)
2012-06-28 13:17 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-06-28 13:10:31 PDT
Improve compositing logging output
Comment 1 Simon Fraser (smfr) 2012-06-28 13:17:15 PDT
Created attachment 149993 [details]
Patch
Comment 2 Tim Horton 2012-06-28 13:23:24 PDT
Comment on attachment 149993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149993&action=review

> Source/WebCore/ChangeLog:11
> +        2. Show element classnames

s/classnames/class names/?

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:518
> +    return static_cast<double>(4 * size().width()) * size().height();

Can we strictly assume {RGBA (in whatever order)}8888 for everyone?

> Source/WebCore/rendering/RenderLayerBacking.cpp:1544
> +            name += " id=\'" + static_cast<Element*>(node)->getIdAttribute() + "\'";

This is going to be awesome.
Comment 3 Simon Fraser (smfr) 2012-06-28 13:28:58 PDT
http://trac.webkit.org/changeset/121461