Bug 90011 - Convert editing/deleting/delete-3959464-fix.html, delete-at-paragraph-boundaries-001.html, merge-into-empty-block-1.html and merge-into-empty-block-2.html to dump-as-markup tests
Summary: Convert editing/deleting/delete-3959464-fix.html, delete-at-paragraph-boundar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 54535
  Show dependency tree / graph
 
Reported: 2012-06-26 13:45 PDT by Ryosuke Niwa
Modified: 2012-06-26 21:03 PDT (History)
6 users (show)

See Also:

Attachments
Patch (72.97 KB, patch)
2012-06-26 13:45 PDT, Ryosuke Niwa 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-06-26 13:45:01 PDT 
Convert editing/deleting/delete-3959464-fix.html, delete-at-paragraph-boundaries-001.html, merge-into-empty-block-1.html and merge-into-empty-block-2.html to dump-as-markup tests
Comment 1 Ryosuke Niwa 2012-06-26 13:45:57 PDT 
Created attachment 149598 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-06-26 13:58:18 PDT 
Comment on attachment 149598 [details]
Patch

Converting tests is good for the soul. :)
Comment 3 Ryosuke Niwa 2012-06-26 13:59:59 PDT 
Thanks!
Comment 4 Ryosuke Niwa 2012-06-26 14:06:36 PDT 
Committed as r121286.
Comment 5 Ryosuke Niwa 2012-06-26 14:47:14 PDT 
Fixed a test in http://trac.webkit.org/changeset/121290.
Comment 6 Hin-Chung Lam 2012-06-26 20:49:39 PDT 
Test is still failing because expectations need to be regenerated. Reopening this bug.
Comment 7 Hin-Chung Lam 2012-06-26 20:50:06 PDT 
Whoops forgot to reopen.
Comment 8 Ryosuke Niwa 2012-06-26 20:56:30 PDT 
(In reply to comment #6)
> Test is still failing because expectations need to be regenerated. Reopening this bug.

Please just rebaseline then.
Comment 9 Ryosuke Niwa 2012-06-26 21:03:42 PDT 
Rebaselined in http://trac.webkit.org/changeset/121318.