Bug 89531 - Pass ScriptValue by const ref where possible
Summary: Pass ScriptValue by const ref where possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 16:53 PDT by Adam Klein
Modified: 2012-06-19 20:27 PDT (History)
13 users (show)

See Also:

Attachments
Patch (16.07 KB, patch)
2012-06-19 16:57 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Tentative patch for landing - fix JSC build (16.76 KB, patch)
2012-06-19 17:31 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2012-06-19 16:53:30 PDT 
Pass ScriptValue by const ref where possible
Comment 1 Adam Klein 2012-06-19 16:57:48 PDT 
Created attachment 148461 [details]
Patch
Comment 2 Kentaro Hara 2012-06-19 17:10:24 PDT 
Comment on attachment 148461 [details]
Patch

Looks OK. This is one of the things I wanted to fix:)
Comment 3 Adam Klein 2012-06-19 17:31:16 PDT 
Created attachment 148470 [details]
Tentative patch for landing - fix JSC build
Comment 4 WebKit Review Bot 2012-06-19 20:27:45 PDT 
Comment on attachment 148470 [details]
Tentative patch for landing - fix JSC build

Clearing flags on attachment: 148470

Committed r120791: <http://trac.webkit.org/changeset/120791>
Comment 5 WebKit Review Bot 2012-06-19 20:27:51 PDT 
All reviewed patches have been landed.  Closing bug.