Bug 89424 - [Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
Summary: [Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-18 22:58 PDT by Andy Estes
Modified: 2012-06-18 23:35 PDT (History)
0 users

See Also:

Attachments
Patch (1.36 KB, patch)
2012-06-18 23:00 PDT, Andy Estes 		mitz: review+
aestes: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2012-06-18 22:58:33 PDT 
[Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
Comment 1 Andy Estes 2012-06-18 23:00:04 PDT 
Created attachment 148252 [details]
Patch
Comment 2 mitz 2012-06-18 23:09:08 PDT 
Comment on attachment 148252 [details]
Patch

Could have used a RetainPtr here.
Comment 3 Andy Estes 2012-06-18 23:33:53 PDT 
Committed r120680: <http://trac.webkit.org/changeset/120680>
Comment 4 Andy Estes 2012-06-18 23:35:22 PDT 
(In reply to comment #2)
> (From update of attachment 148252 [details])
> Could have used a RetainPtr here.

Landed with a RetainPtr.