Bug 88915 - [BlackBerry] Crash when rendering web page that's being destroyed
Summary: [BlackBerry] Crash when rendering web page that's being destroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-12 14:17 PDT by Arvid Nilsson
Modified: 2012-06-12 15:52 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2012-06-12 14:49 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-06-12 14:17:27 PDT
At one stage in the tear down of web page, the compositor is disconnected from the web page so WebPageCompositorPrivate::m_webPage is 0.

However, WebPageCompositorPrivate::render() doesn't check validity of m_webPage before calling into WebPage::compositor() to see if we're really the web page's compositor.
Comment 1 Arvid Nilsson 2012-06-12 14:27:08 PDT
This is PR164943
Comment 2 Arvid Nilsson 2012-06-12 14:49:29 PDT
Created attachment 147169 [details]
Patch
Comment 3 Rob Buis 2012-06-12 14:52:30 PDT
Comment on attachment 147169 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2012-06-12 15:52:45 PDT
Comment on attachment 147169 [details]
Patch

Clearing flags on attachment: 147169

Committed r120134: <http://trac.webkit.org/changeset/120134>
Comment 5 WebKit Review Bot 2012-06-12 15:52:49 PDT
All reviewed patches have been landed.  Closing bug.