Bug 88792 - garden-o-matic should rebaseline tests in parallel
: garden-o-matic should rebaseline tests in parallel
Status: NEW
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-11 11:11 PDT by Ojan Vafai
Modified: 2012-06-13 10:32 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-06-11 11:11:17 PDT
Now that it does the rebaselines for the baselines of an individual test in parallel, it's many many times faster, but when I'm doing hundreds of tests, it still takes ~20 minutes to catch up. When the server sees that there are multiple tests enqueued, it should batch them together so that they can all be done in parallel.
Comment 1 Ojan Vafai 2012-06-12 17:52:27 PDT
For reference, rebaselining 700 windows only failures took ~8 minutes from San Francisco. That's good enough, but we can do better. Also, in the process, we could share code better with "webkit-patch rebaseline-expectations" so that gets the parallelism benefits as well (right now the latter doesn't do anything in parallel, where the garden-o-matic does the expectations for each individual test in parallel).
Comment 2 Dirk Pranke 2012-06-13 10:32:16 PDT
I think garden-o-matic is actually rebaselining all of the test in a given cluster in parallel, but it then only optimizes each test serially. We can probably do the latter in parallel as well by separating out the scm operations from the hashing and de-duping, but I suspect that will still be only a 5-10% speedup. 

I need to look at the logs to see if there are more opportunities for parallelism.