Bug 88558 - [Chromium] Initialize a member variable.
Summary: [Chromium] Initialize a member variable.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Hawkins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-07 11:18 PDT by James Hawkins
Modified: 2013-04-15 07:44 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2012-06-07 11:19 PDT, James Hawkins
no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2012-06-07 11:24 PDT, James Hawkins
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Hawkins 2012-06-07 11:18:32 PDT
[Chromium] Initialize a member variable.
Comment 1 James Hawkins 2012-06-07 11:19:00 PDT
Created attachment 146335 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-07 11:20:17 PDT
Attachment 146335 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 James Hawkins 2012-06-07 11:24:20 PDT
Created attachment 146338 [details]
Patch
Comment 4 Ryosuke Niwa 2012-08-07 23:43:19 PDT
Comment on attachment 146338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146338&action=review

Okay.

> Source/WebKit/chromium/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).

This line should appear above the long description.
Comment 5 WebKit Review Bot 2012-08-08 08:17:28 PDT
Comment on attachment 146338 [details]
Patch

Rejecting attachment 146338 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
it/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/chromium/src/WebHelperPluginImpl.cpp
Hunk #1 FAILED at 98.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/src/WebHelperPluginImpl.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13456510