Bug 88431 - IndexedDB: Infinite recursion in IDBObjectStore.openCursor(key, legacy_constant)
Summary: IndexedDB: Infinite recursion in IDBObjectStore.openCursor(key, legacy_constant)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-06 10:17 PDT by Joshua Bell
Modified: 2012-06-06 14:01 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.53 KB, patch)
2012-06-06 10:20 PDT, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-06-06 10:17:50 PDT
IndexedDB: Infinite recursion in IDBObjectStore.openCursor(key, legacy_constant)
Comment 1 Joshua Bell 2012-06-06 10:20:06 PDT
Created attachment 146058 [details]
Patch
Comment 2 Joshua Bell 2012-06-06 10:21:41 PDT
Originally noted in https://bugs.webkit.org/show_bug.cgi?id=84894

View in context: https://bugs.webkit.org/attachment.cgi?id=140537&action=review

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:301
> +    return openCursor(context, key, direction, ec);

Should be keyRange, not key. This call leads to infinite recursion.
Comment 3 Joshua Bell 2012-06-06 10:22:00 PDT
alecflett@ please sanity check?

tony@ - r?
Comment 4 Alec Flett 2012-06-06 10:57:01 PDT
LGTM
Comment 5 WebKit Review Bot 2012-06-06 14:01:30 PDT
Comment on attachment 146058 [details]
Patch

Clearing flags on attachment: 146058

Committed r119615: <http://trac.webkit.org/changeset/119615>
Comment 6 WebKit Review Bot 2012-06-06 14:01:35 PDT
All reviewed patches have been landed.  Closing bug.