Bug 88347 - Eliminate some comparisons of RefPtr with 0 to prepare for possible future changes to RefPtr
Summary: Eliminate some comparisons of RefPtr with 0 to prepare for possible future ch...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-05 11:09 PDT by Darin Adler
Modified: 2013-08-25 10:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.75 KB, patch)
2012-06-05 11:21 PDT, Darin Adler
sam: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2012-06-05 11:09:16 PDT
Eliminate some comparisons of RefPtr with 0 to prepare for possible future changes to RefPtr
Comment 1 Darin Adler 2012-06-05 11:21:34 PDT
Created attachment 145845 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-02 22:00:35 PST
Comment on attachment 145845 [details]
Patch

Rejecting attachment 145845 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 145845, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ile Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/css/CSSParser.cpp
Hunk #1 succeeded at 6084 (offset 813 lines).
patching file Source/WebCore/rendering/RenderLayerBacking.h
Hunk #1 FAILED at 74.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderLayerBacking.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Sam Weinig']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://webkit-commit-queue.appspot.com/results/16797900
Comment 3 Eric Seidel (no email) 2013-03-02 22:19:18 PST
Comment on attachment 145845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145845&action=review

> Source/WebCore/rendering/RenderLayerBacking.h:77
> +    bool hasClippingLayer() const { return m_clippingLayer; }

I would probably have written !! to make the bool conversion explicit.  But I guess that's more typing.  Old habits. :)
Comment 4 Darin Adler 2013-08-25 10:24:04 PDT
I think I’ll drop this.