Bug 88302 - [Qt][Win] Fix linking WTF with ICU
Summary: [Qt][Win] Fix linking WTF with ICU
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 88300
  Show dependency treegraph
 
Reported: 2012-06-05 01:03 PDT by Csaba Osztrogonác
Modified: 2012-06-07 04:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.17 KB, patch)
2012-06-05 05:33 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-06-05 01:03:04 PDT
Linking WTF fails because of missing ICU libraries.
(It seems the lib names are different on Windows.)
Comment 1 Csaba Osztrogonác 2012-06-05 05:33:09 PDT
Created attachment 145768 [details]
Patch
Comment 2 Simon Hausmann 2012-06-05 14:31:59 PDT
Comment on attachment 145768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145768&action=review

> Source/WTF/WTF.pri:30
> +            win32-*: LIBS += -licuin -licuuc -licudt

I think that you can just use win32 instead of win32-*. The former is also what we use in Qt.
Comment 3 Csaba Osztrogonác 2012-06-07 04:40:47 PDT
(In reply to comment #2)
> (From update of attachment 145768 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145768&action=review
> 
> > Source/WTF/WTF.pri:30
> > +            win32-*: LIBS += -licuin -licuuc -licudt
> 
> I think that you can just use win32 instead of win32-*. The former is also what we use in Qt.

Good point. Fixed patch landed in http://trac.webkit.org/changeset/119704