RESOLVED FIXED 88082
[Qt] Remove QtViewportInteractionEngine::pageItemSizeChanged 
https://bugs.webkit.org/show_bug.cgi?id=88082
Summary [Qt] Remove QtViewportInteractionEngine::pageItemSizeChanged
Allan Sandfeld Jensen
Reported 2012-06-01 05:50:58 PDT
This function no longer serves any practical purpose and is also currently a cause of some flickering.
Attachments
Patch (3.37 KB, patch)
2012-06-01 05:55 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (3.44 KB, patch)
2012-06-01 06:11 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-06-01 05:55:25 PDT
Created attachment 145281 [details] Patch
WebKit Review Bot
Comment 2 2012-06-01 05:59:14 PDT
Comment on attachment 145281 [details] Patch Rejecting attachment 145281 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: onEngine.cpp Hunk #1 FAILED at 144. Hunk #2 succeeded at 734 with fuzz 1 (offset 59 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp.rej patching file Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h Hunk #1 succeeded at 82 with fuzz 1 (offset -20 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12865546
Allan Sandfeld Jensen
Comment 3 2012-06-01 06:11:41 PDT
Created attachment 145285 [details] Patch
WebKit Review Bot
Comment 4 2012-06-01 08:43:20 PDT
Comment on attachment 145285 [details] Patch Clearing flags on attachment: 145285 Committed r119234: <http://trac.webkit.org/changeset/119234>
WebKit Review Bot
Comment 5 2012-06-01 08:43:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.