Bug 88082 - [Qt] Remove QtViewportInteractionEngine::pageItemSizeChanged
Summary: [Qt] Remove QtViewportInteractionEngine::pageItemSizeChanged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 05:50 PDT by Allan Sandfeld Jensen
Modified: 2012-06-01 08:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2012-06-01 05:55 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Patch (3.44 KB, patch)
2012-06-01 06:11 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-06-01 05:50:58 PDT 
This function no longer serves any practical purpose and is also currently a cause of some flickering.
Comment 1 Allan Sandfeld Jensen 2012-06-01 05:55:25 PDT 
Created attachment 145281 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-01 05:59:14 PDT 
Comment on attachment 145281 [details]
Patch

Rejecting attachment 145281 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
onEngine.cpp
Hunk #1 FAILED at 144.
Hunk #2 succeeded at 734 with fuzz 1 (offset 59 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp.rej
patching file Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h
Hunk #1 succeeded at 82 with fuzz 1 (offset -20 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12865546
Comment 3 Allan Sandfeld Jensen 2012-06-01 06:11:41 PDT 
Created attachment 145285 [details]
Patch
Comment 4 WebKit Review Bot 2012-06-01 08:43:20 PDT 
Comment on attachment 145285 [details]
Patch

Clearing flags on attachment: 145285

Committed r119234: <http://trac.webkit.org/changeset/119234>
Comment 5 WebKit Review Bot 2012-06-01 08:43:25 PDT 
All reviewed patches have been landed.  Closing bug.