RESOLVED FIXED 87796
[chromium] port webframe_unittest.cc to webkit_unit_tests 
https://bugs.webkit.org/show_bug.cgi?id=87796
Summary [chromium] port webframe_unittest.cc to webkit_unit_tests
Tony Chang
Reported 2012-05-29 17:13:45 PDT
[chromium] port webframe_unittest.cc to webkit_unit_tests
Attachments
Patch (4.39 KB, patch)
2012-05-29 17:14 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.35 KB, patch)
2012-05-30 09:35 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-05-29 17:14:58 PDT
Created attachment 144652 [details] Patch
James Robinson
Comment 2 2012-05-29 17:23:13 PDT
Comment on attachment 144652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144652&action=review > Source/WebKit/chromium/tests/WebFrameTest.cpp:652 > + WebSize size(640, 480); > + webView->resize(size); nit: could fold this in to the resize call, no need for a temporary
Tony Chang
Comment 3 2012-05-30 09:35:24 PDT
Created attachment 144839 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-05-30 12:53:38 PDT
Comment on attachment 144839 [details] Patch for landing Clearing flags on attachment: 144839 Committed r118958: <http://trac.webkit.org/changeset/118958>
WebKit Review Bot
Comment 5 2012-05-30 12:53:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.