Bug 87706 - [BlackBerry] Refactoring http/proxy authentication to use authcallback mechanism introduced with libcurl
Summary: [BlackBerry] Refactoring http/proxy authentication to use authcallback mechan...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 01:06 PDT by Jonathan Dong
Modified: 2012-05-29 10:14 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.80 KB, patch)
2012-05-29 02:34 PDT, Jonathan Dong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Dong 2012-05-29 01:06:33 PDT 
RIM PR: 152357

We are trying to use libcurl's new feature: authentication callback mechanism to refactor our current implementation of http/proxy authentication process. This feature in libcurl is contributed by Joe Mason and will be an important new feature in libcurl's next release. For now we have a work around solution in platform repository to simulate the same logic.

With this mechanism we don't need to handle all the intermediate authentication headers for some of the http authentication scheme, what we only need to do is to provide libcurl with the credentials when it calls the authentication callback.
Comment 1 Jonathan Dong 2012-05-29 02:34:37 PDT 
Created attachment 144492 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-29 10:14:34 PDT 
Comment on attachment 144492 [details]
Patch

Clearing flags on attachment: 144492

Committed r118801: <http://trac.webkit.org/changeset/118801>
Comment 3 WebKit Review Bot 2012-05-29 10:14:39 PDT 
All reviewed patches have been landed.  Closing bug.