Bug 87290 - AX: Prevents assertion from potentially dereferencing null pointer.
Summary: AX: Prevents assertion from potentially dereferencing null pointer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Tseng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 11:17 PDT by David Tseng
Modified: 2012-05-23 17:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2012-05-23 11:21 PDT, David Tseng 		no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2012-05-23 11:51 PDT, David Tseng 		no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2012-05-23 15:23 PDT, David Tseng 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Tseng 2012-05-23 11:17:16 PDT 
ax: Prevents assertion from potentially dereferencing null pointer.
Comment 1 David Tseng 2012-05-23 11:21:27 PDT 
Created attachment 143601 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-23 11:24:02 PDT 
Attachment 143601 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 chris fleizach 2012-05-23 11:48:06 PDT 
Comment on attachment 143601 [details]
Patch

fix style issue, otherwise looks ok
Also the title of the bug should be capital "AX" not lowercase
Comment 4 David Tseng 2012-05-23 11:51:03 PDT 
Created attachment 143607 [details]
Patch
Comment 5 chris fleizach 2012-05-23 12:10:58 PDT 
(In reply to comment #4)
> Created an attachment (id=143607) [details]
> Patch

title of bug should be uppercase AX
Comment 6 David Tseng 2012-05-23 15:23:39 PDT 
Created attachment 143662 [details]
Patch
Comment 7 chris fleizach 2012-05-23 15:24:15 PDT 
Comment on attachment 143662 [details]
Patch

looks good. i assume you want CQ too
Comment 8 WebKit Review Bot 2012-05-23 17:30:07 PDT 
Comment on attachment 143662 [details]
Patch

Clearing flags on attachment: 143662

Committed r118281: <http://trac.webkit.org/changeset/118281>
Comment 9 WebKit Review Bot 2012-05-23 17:30:12 PDT 
All reviewed patches have been landed.  Closing bug.