Bug 87271 - Change acceptMIMETypes member to acceptTypes now that file extensions are legal accept types
Summary: Change acceptMIMETypes member to acceptTypes now that file extensions are leg...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raymes Khoury
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 09:36 PDT by Raymes Khoury
Modified: 2012-05-23 12:09 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.98 KB, patch)
2012-05-23 10:03 PDT, Raymes Khoury
no flags Details | Formatted Diff | Diff
Patch (3.25 KB, patch)
2012-05-23 10:05 PDT, Raymes Khoury
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raymes Khoury 2012-05-23 09:36:49 PDT
Change acceptMIMETypes member to acceptTypes now that file extensions are legal accept types
Comment 1 Raymes Khoury 2012-05-23 10:03:16 PDT
In the past the <input> element only allowed filtering by MIME types however it now allows them to be filtered by file extension as well. Refer to http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#attr-input-accept

Currently this does not change the implementation of the <input> "accept" paramater for Webkit. It merely changes the struct used by Chromium in order to add pepper support for filtering files by file extensions (see http://codereview.chromium.org/10414085/) and also to support the webkit implementation in the future.
Comment 2 Raymes Khoury 2012-05-23 10:03:42 PDT
Created attachment 143585 [details]
Patch
Comment 3 WebKit Review Bot 2012-05-23 10:05:15 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Raymes Khoury 2012-05-23 10:05:54 PDT
Created attachment 143586 [details]
Patch
Comment 5 WebKit Review Bot 2012-05-23 12:08:58 PDT
Comment on attachment 143586 [details]
Patch

Clearing flags on attachment: 143586

Committed r118223: <http://trac.webkit.org/changeset/118223>
Comment 6 WebKit Review Bot 2012-05-23 12:09:08 PDT
All reviewed patches have been landed.  Closing bug.