Bug 87268 - [Chromium] Move themeEngine to Platform.h
Summary: [Chromium] Move themeEngine to Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency tree / graph
 
Reported: 2012-05-23 08:45 PDT by Mark Pilgrim (Google)
Modified: 2012-05-23 13:42 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.57 KB, patch)
2012-05-23 08:46 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (40.83 KB, patch)
2012-05-23 12:01 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-05-23 08:45:30 PDT 
[Chromium] Move themeEngine to Platform.h
Comment 1 Mark Pilgrim (Google) 2012-05-23 08:46:08 PDT 
Created attachment 143575 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-05-23 08:47:41 PDT 
This is obviously only half the story; the other half is taking all the paint* functions out of PlatformSupport.cpp/h and calling them directly from ScrollbarThemeChromium*.cpp. That'll be a followup bug.
Comment 3 WebKit Review Bot 2012-05-23 08:48:51 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Adam Barth 2012-05-23 08:57:55 PDT 
Comment on attachment 143575 [details]
Patch

This is fine, but we should move the WebThemeEngine.h files too.
Comment 5 Mark Pilgrim (Google) 2012-05-23 12:01:49 PDT 
Created attachment 143610 [details]
Patch
Comment 6 Mark Pilgrim (Google) 2012-05-23 12:02:27 PDT 
Comment on attachment 143610 [details]
Patch

Now moves WebThemeEngine files to new subdirectories in Platform/chromium/public/
Comment 7 WebKit Review Bot 2012-05-23 13:42:36 PDT 
Comment on attachment 143610 [details]
Patch

Clearing flags on attachment: 143610

Committed r118237: <http://trac.webkit.org/changeset/118237>
Comment 8 WebKit Review Bot 2012-05-23 13:42:41 PDT 
All reviewed patches have been landed.  Closing bug.