RESOLVED FIXED 87243
[Qt][WK2] Small refactoring WebPage::confirmComposition. 
https://bugs.webkit.org/show_bug.cgi?id=87243
Summary [Qt][WK2] Small refactoring WebPage::confirmComposition.
Michael Brüning
Reported 2012-05-23 03:31:37 PDT
[Qt][WK2] Small refactoring WebPage::confirmComposition.
Attachments
Patch (2.25 KB, patch)
2012-05-23 03:33 PDT, Michael Brüning 		no flags
DetailsFormatted DiffDiff
Patch (2.27 KB, patch)
2012-05-23 04:49 PDT, Michael Brüning 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Brüning
Comment 1 2012-05-23 03:33:31 PDT
Created attachment 143521 [details] Patch
WebKit Review Bot
Comment 2 2012-05-23 03:38:44 PDT
Attachment 143521 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Brüning
Comment 3 2012-05-23 04:49:50 PDT
Created attachment 143534 [details] Patch
WebKit Review Bot
Comment 4 2012-05-23 06:03:31 PDT
Comment on attachment 143534 [details] Patch Clearing flags on attachment: 143534 Committed r118165: <http://trac.webkit.org/changeset/118165>
WebKit Review Bot
Comment 5 2012-05-23 06:03:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.