Bug 87243 - [Qt][WK2] Small refactoring WebPage::confirmComposition.
Summary: [Qt][WK2] Small refactoring WebPage::confirmComposition.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Brüning
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-23 03:31 PDT by Michael Brüning
Modified: 2012-05-23 06:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2012-05-23 03:33 PDT, Michael Brüning 		no flags Details | Formatted Diff | Diff
Patch (2.27 KB, patch)
2012-05-23 04:49 PDT, Michael Brüning 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Brüning 2012-05-23 03:31:37 PDT 
[Qt][WK2] Small refactoring WebPage::confirmComposition.
Comment 1 Michael Brüning 2012-05-23 03:33:31 PDT 
Created attachment 143521 [details]
Patch
Comment 2 WebKit Review Bot 2012-05-23 03:38:44 PDT 
Attachment 143521 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Brüning 2012-05-23 04:49:50 PDT 
Created attachment 143534 [details]
Patch
Comment 4 WebKit Review Bot 2012-05-23 06:03:31 PDT 
Comment on attachment 143534 [details]
Patch

Clearing flags on attachment: 143534

Committed r118165: <http://trac.webkit.org/changeset/118165>
Comment 5 WebKit Review Bot 2012-05-23 06:03:48 PDT 
All reviewed patches have been landed.  Closing bug.