Bug 87209 - [V8] Pass Isolate to v8::Null() in custom bindings (Part 2)
Summary: [V8] Pass Isolate to v8::Null() in custom bindings (Part 2)
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency treegraph
 
Reported: 2012-05-22 21:44 PDT by Kentaro Hara
Modified: 2012-05-23 17:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (27.42 KB, patch)
2012-05-22 21:45 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-05-22 21:44:01 PDT
The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to v8::Null() in custom bindings.
Comment 1 Kentaro Hara 2012-05-22 21:45:28 PDT
Created attachment 143457 [details]
Patch
Comment 2 Adam Barth 2012-05-22 23:01:12 PDT
Comment on attachment 143457 [details]
Patch

I am the very model of a modern rubberstamp machine.  With information vegetable, animal, and isolated.
Comment 3 WebKit Review Bot 2012-05-23 00:10:42 PDT
Comment on attachment 143457 [details]
Patch

Clearing flags on attachment: 143457

Committed r118134: <http://trac.webkit.org/changeset/118134>
Comment 4 WebKit Review Bot 2012-05-23 00:11:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Kentaro Hara 2012-05-23 17:09:33 PDT
Reverted r118134 for reason:

some LayoutTests crash since the patch passes a NULL to Null(isolate)

Committed r118272: <http://trac.webkit.org/changeset/118272>