RESOLVED WONTFIX 87209
[V8] Pass Isolate to v8::Null() in custom bindings (Part 2) 
https://bugs.webkit.org/show_bug.cgi?id=87209
Summary [V8] Pass Isolate to v8::Null() in custom bindings (Part 2)
Kentaro Hara
Reported 2012-05-22 21:44:01 PDT
The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to v8::Null() in custom bindings.
Attachments
Patch (27.42 KB, patch)
2012-05-22 21:45 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-22 21:45:28 PDT
Created attachment 143457 [details] Patch
Adam Barth
Comment 2 2012-05-22 23:01:12 PDT
Comment on attachment 143457 [details] Patch I am the very model of a modern rubberstamp machine. With information vegetable, animal, and isolated.
WebKit Review Bot
Comment 3 2012-05-23 00:10:42 PDT
Comment on attachment 143457 [details] Patch Clearing flags on attachment: 143457 Committed r118134: <http://trac.webkit.org/changeset/118134>
WebKit Review Bot
Comment 4 2012-05-23 00:11:04 PDT
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 5 2012-05-23 17:09:33 PDT
Reverted r118134 for reason: some LayoutTests crash since the patch passes a NULL to Null(isolate) Committed r118272: <http://trac.webkit.org/changeset/118272>
Note You need to log in before you can comment on or make changes to this bug.