Bug 86774 - Add more descriptive warnings for framebuffer incomplete conditions
Summary: Add more descriptive warnings for framebuffer incomplete conditions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-17 14:18 PDT by Gregg Tavares
Modified: 2012-05-17 15:27 PDT (History)
3 users (show)

See Also:


Attachments
Patch (17.74 KB, patch)
2012-05-17 14:24 PDT, Gregg Tavares
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2012-05-17 14:18:11 PDT
Add more descriptive warnings for framebuffer incomplete conditions
Comment 1 Gregg Tavares 2012-05-17 14:24:19 PDT
Created attachment 142555 [details]
Patch
Comment 2 Kenneth Russell 2012-05-17 14:44:34 PDT
Comment on attachment 142555 [details]
Patch

Looks good. I was going to comment that using String& rather than const char** might be "cleaner", but realized that you don't want to have any const char* -> String conversion overhead when calling around in the common case. r=me
Comment 3 WebKit Review Bot 2012-05-17 15:27:11 PDT
Comment on attachment 142555 [details]
Patch

Clearing flags on attachment: 142555

Committed r117506: <http://trac.webkit.org/changeset/117506>
Comment 4 WebKit Review Bot 2012-05-17 15:27:14 PDT
All reviewed patches have been landed.  Closing bug.