Bug 86529 - rename display:-webkit-flexbox to display:-webkit-flex
Summary: rename display:-webkit-flexbox to display:-webkit-flex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency treegraph
 
Reported: 2012-05-15 14:29 PDT by Tony Chang
Modified: 2012-05-16 20:18 PDT (History)
7 users (show)

See Also:


Attachments
Patch (55.00 KB, patch)
2012-05-15 15:52 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (871.93 KB, application/zip)
2012-05-15 20:50 PDT, WebKit Review Bot
no flags Details
Patch for landing (55.68 KB, patch)
2012-05-16 12:17 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-05-15 14:29:03 PDT
The spec changed.
Comment 2 Tony Chang 2012-05-15 15:52:54 PDT
Created attachment 142087 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-05-15 15:59:13 PDT
Comment on attachment 142087 [details]
Patch

This is the new-flex I assume, not the deprecated one? :)
Comment 4 Tony Chang 2012-05-15 16:01:06 PDT
(In reply to comment #3)
> (From update of attachment 142087 [details])
> This is the new-flex I assume, not the deprecated one? :)

Yes.
Comment 5 WebKit Review Bot 2012-05-15 20:49:58 PDT
Comment on attachment 142087 [details]
Patch

Attachment 142087 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12706530

New failing tests:
fast/multicol/span/clone-flexbox.html
Comment 6 WebKit Review Bot 2012-05-15 20:50:03 PDT
Created attachment 142137 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 Tony Chang 2012-05-16 12:17:59 PDT
Created attachment 142321 [details]
Patch for landing
Comment 8 WebKit Review Bot 2012-05-16 20:18:47 PDT
Comment on attachment 142321 [details]
Patch for landing

Clearing flags on attachment: 142321

Committed r117385: <http://trac.webkit.org/changeset/117385>
Comment 9 WebKit Review Bot 2012-05-16 20:18:52 PDT
All reviewed patches have been landed.  Closing bug.