86513 – [Chromium] CCTimer::isActive() is incorrect inside tick callback

Bug 86513 - [Chromium] CCTimer::isActive() is incorrect inside tick callback

Summary: [Chromium] CCTimer::isActive() is incorrect inside tick callback

Attachments
Patch (3.71 KB, patch) 2012-05-15 17:18 PDT, Tien-Ren Chen	no flags	Details \| Formatted Diff \| Diff
Patch (3.22 KB, patch) 2012-05-15 17:21 PDT, Tien-Ren Chen	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Sievers 2012-05-15 12:58:15 PDT

Need to move clearing of m_task to before calling onTimerFired()

Comment 1 Tien-Ren Chen 2012-05-15 17:18:37 PDT

Created attachment 142100 [details]
Patch

Comment 2 Tien-Ren Chen 2012-05-15 17:21:17 PDT

Created attachment 142101 [details]
Patch

Comment 3 James Robinson 2012-05-15 17:24:19 PDT

Comment on attachment 142101 [details]
Patch

R=me

Comment 4 WebKit Review Bot 2012-05-15 21:07:06 PDT

Comment on attachment 142101 [details]
Patch

Clearing flags on attachment: 142101

Committed r117214: <http://trac.webkit.org/changeset/117214>

Comment 5 WebKit Review Bot 2012-05-15 21:07:12 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Nat Duca 2012-05-15 21:08:13 PDT

Thanks Tian-Ren! Very appreciated.