Bug 85869 - OS(ANDROID) JNI AttachCurrentThread take JNIEnv** as a parameter, not void**
Summary: OS(ANDROID) JNI AttachCurrentThread take JNIEnv** as a parameter, not void**
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 66687
  Show dependency treegraph
 
Reported: 2012-05-08 00:09 PDT by Adam Barth
Modified: 2012-05-08 01:59 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2012-05-08 00:13 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2012-05-08 01:19 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-05-08 00:09:26 PDT
Modern JNI AttachCurrentThread take JNIEnv** as a parameter, not void**
Comment 1 Adam Barth 2012-05-08 00:13:08 PDT
Created attachment 140685 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-08 00:13:41 PDT
Comment on attachment 140685 [details]
Patch

So long as this passes all the EWSes, this is good to go.
Comment 3 Build Bot 2012-05-08 00:31:42 PDT
Comment on attachment 140685 [details]
Patch

Attachment 140685 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12646272
Comment 4 Adam Barth 2012-05-08 01:06:18 PDT
Sigh.  Mac and its ancient Java.
Comment 5 Adam Barth 2012-05-08 01:19:00 PDT
Created attachment 140687 [details]
Patch
Comment 6 Eric Seidel (no email) 2012-05-08 01:25:13 PDT
Comment on attachment 140687 [details]
Patch

OK.
Comment 7 WebKit Review Bot 2012-05-08 01:59:27 PDT
Comment on attachment 140687 [details]
Patch

Clearing flags on attachment: 140687

Committed r116405: <http://trac.webkit.org/changeset/116405>
Comment 8 WebKit Review Bot 2012-05-08 01:59:41 PDT
All reviewed patches have been landed.  Closing bug.