Bug 85816 – REGRESSION(r116334): Broke the Chromium Win/Mac compile (Requested by ojan_gardening on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/116334 broke the build:
Broke the Chromium Win/Mac compile (Requested by ojan_gardening on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 140573 [details]
ROLLOUT of r116334

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Ojan Vafai]

In file included from third_party/WebKit/Source/WebCore/platform/graphics/chromium/LinkHighlightLayerDelegate.cpp:28:
third_party/WebKit/Source/WebCore/platform/graphics/chromium/LinkHighlightLayerDelegate.h:49:18: error: 'didScroll' marked 'override' but does not override any member functions
    virtual void didScroll(const IntSize&) OVERRIDE;
                 ^
1 error generated.
make: *** [out/Release/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/graphics/chromium/LinkHighlightLayerDelegate.o] Error 1
  CXX(target) out/Release/obj.target/webcore_remaining/third_party/WebKit/Source/WebCore/bindings/ScriptControllerBase.o
  CXX(target) out/Release/obj.target/webcore_remaining/third_party/WebKit/Source/WebCore/bindings/generic/ActiveDOMCallback.o
In file included from third_party/WebKit/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:56:
third_party/WebKit/Source/WebCore/platform/graphics/chromium/LinkHighlightLayerDelegate.h:49:18: error: 'didScroll' marked 'override' but does not override any member functions
    virtual void didScroll(const IntSize&) OVERRIDE;
                 ^
1 error generated.
make: *** [out/Release/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.o] Error 1

[WebKit Review Bot]

Comment on attachment 140573 [details]
ROLLOUT of r116334

Clearing flags on attachment: 140573

Committed r116342: <http://trac.webkit.org/changeset/116342>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.