Bug 85796 - MediaStream API: Rename MediaStreamCenter::didConstructMediaStream
Summary: MediaStream API: Rename MediaStreamCenter::didConstructMediaStream
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
Depends on:
Blocks: 56459
  Show dependency treegraph
Reported: 2012-05-07 06:02 PDT by Tommy Widenflycht
Modified: 2012-05-07 10:55 PDT (History)
10 users (show)

See Also:

Patch (7.39 KB, patch)
2012-05-07 06:16 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (9.32 KB, patch)
2012-05-07 06:36 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-05-07 06:02:37 PDT
Renamed MediaStreamCenter::didConstructMediaStream to didCreateMediaStream, and change so that it is only called for MediaStreams created from JS.
Also in the chromium embedder send out the WebMediaStreamDescriptor non-const instead.
Comment 1 Tommy Widenflycht 2012-05-07 06:16:05 PDT
Created attachment 140516 [details]
Comment 2 WebKit Review Bot 2012-05-07 06:18:51 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Gustavo Noronha (kov) 2012-05-07 06:21:39 PDT
Comment on attachment 140516 [details]

Attachment 140516 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12644155
Comment 4 Tommy Widenflycht 2012-05-07 06:36:19 PDT
Created attachment 140521 [details]
Comment 5 WebKit Review Bot 2012-05-07 10:55:49 PDT
Comment on attachment 140521 [details]

Clearing flags on attachment: 140521

Committed r116321: <http://trac.webkit.org/changeset/116321>
Comment 6 WebKit Review Bot 2012-05-07 10:55:54 PDT
All reviewed patches have been landed.  Closing bug.