Bug 85714 - Web Inspector: make JavaScriptSourceFrame use breakpoint manager's breakpoints store.
Summary: Web Inspector: make JavaScriptSourceFrame use breakpoint manager's breakpoint...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-05-05 08:51 PDT by Pavel Feldman
Modified: 2012-05-07 23:56 PDT (History)
10 users (show)

See Also:

Patch (18.73 KB, patch)
2012-05-05 09:13 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (19.88 KB, patch)
2012-05-05 09:33 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-05-05 08:51:37 PDT
It is currently using its own copy of breakpoints which is not necessary.
Comment 1 Pavel Feldman 2012-05-05 09:13:07 PDT
Created attachment 140404 [details]
Comment 2 Pavel Feldman 2012-05-05 09:33:31 PDT
Created attachment 140407 [details]
Comment 3 Yury Semikhatsky 2012-05-05 23:49:36 PDT
Comment on attachment 140407 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=140407&action=review

> Source/WebCore/ChangeLog:41
> +        Web Inspector: do not create locations for resolved provisional breakpoints

Revert this.

> Source/WebCore/inspector/front-end/BreakpointManager.js:168
> +            breakpoints[i]._isProvisional = true;

Please revert this as it is a part of another change.
Comment 4 Pavel Feldman 2012-05-07 23:56:32 PDT
Committed r116398: <http://trac.webkit.org/changeset/116398>