Bug 85663 - DFG should not Flush GetLocal's
Summary: DFG should not Flush GetLocal's
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-04 14:02 PDT by Filip Pizlo
Modified: 2012-05-04 14:17 PDT (History)
0 users

See Also:


Attachments
the patch (4.37 KB, patch)
2012-05-04 14:04 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (4.95 KB, patch)
2012-05-04 14:12 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-05-04 14:02:20 PDT
Not only is it wasteful but the virtual register allocator gets confused by it.
Comment 1 Filip Pizlo 2012-05-04 14:02:37 PDT
<rdar://problem/11373600>
Comment 2 Filip Pizlo 2012-05-04 14:04:32 PDT
Created attachment 140317 [details]
the patch
Comment 3 Filip Pizlo 2012-05-04 14:12:18 PDT
Created attachment 140320 [details]
the patch

And now, with an expected results file!
Comment 4 Filip Pizlo 2012-05-04 14:17:43 PDT
Landed in http://trac.webkit.org/changeset/116168