Bug 85105 - Fullscreen pop-up logic restored to using processingUserGesture. [Regression]
Summary: Fullscreen pop-up logic restored to using processingUserGesture. [Regression]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vincent Scheib
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 15:49 PDT by Vincent Scheib
Modified: 2012-05-01 21:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.53 KB, patch)
2012-04-27 16:00 PDT, Vincent Scheib
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2012-04-27 15:49:09 PDT
Fullscreen pop-up logic restored to using processingUserGesture.
Comment 1 Vincent Scheib 2012-04-27 16:00:14 PDT
Created attachment 139297 [details]
Patch
Comment 2 Jer Noble 2012-04-27 16:37:56 PDT
Comment on attachment 139297 [details]
Patch

This change looks good to me. The mismatch between domWindow->allowPopups() and the spec is well documented in this new comment.
Comment 3 Jer Noble 2012-04-27 16:37:57 PDT
Comment on attachment 139297 [details]
Patch

This change looks good to me. The mismatch between domWindow->allowPopups() and the spec is well documented in this new comment.
Comment 4 WebKit Review Bot 2012-05-01 21:27:32 PDT
Comment on attachment 139297 [details]
Patch

Clearing flags on attachment: 139297

Committed r115792: <http://trac.webkit.org/changeset/115792>
Comment 5 WebKit Review Bot 2012-05-01 21:27:46 PDT
All reviewed patches have been landed.  Closing bug.