RESOLVED FIXED84997
Delete dead code in Arena.h/cpp 
https://bugs.webkit.org/show_bug.cgi?id=84997
Summary Delete dead code in Arena.h/cpp
Ojan Vafai
Reported 2012-04-26 13:32:57 PDT
Delete dead code in Arena.h/cpp
Attachments
Patch (13.69 KB, patch)
2012-04-26 13:35 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-04-26 13:35:23 PDT
Created attachment 139057 [details] Patch
WebKit Review Bot
Comment 2 2012-04-26 13:38:26 PDT
Attachment 139057 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/Arena.h:77: _a is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.h:78: _nb is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.h:79: _p is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.h:80: _q is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.h:83: Else clause should never be on same line as else (use 2 lines) [whitespace/newline] [4] Source/WebCore/platform/Arena.cpp:67: j_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/Arena.cpp:105: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/Arena.cpp:119: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/Arena.cpp:119: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/platform/Arena.cpp:160: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/Arena.cpp:180: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 11 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2012-04-26 13:47:25 PDT
Comment on attachment 139057 [details] Patch OK. You should use the cq to make sure nothing breaks.
WebKit Review Bot
Comment 4 2012-04-26 17:47:57 PDT
Comment on attachment 139057 [details] Patch Clearing flags on attachment: 139057 Committed r115389: <http://trac.webkit.org/changeset/115389>
WebKit Review Bot
Comment 5 2012-04-26 17:48:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.