Bug 84506 - [chromium] WebFilterOperations API does not compile or dynamically link
Summary: [chromium] WebFilterOperations API does not compile or dynamically link
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-20 16:03 PDT by Dana Jansens
Modified: 2012-04-20 17:23 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.18 KB, patch)
2012-04-20 16:04 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (3.15 KB, patch)
2012-04-20 16:08 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2012-04-20 16:32 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-04-20 16:03:12 PDT
[chromium] Fix API for WebFilterOperations
Comment 1 Dana Jansens 2012-04-20 16:04:01 PDT
Created attachment 138184 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-20 16:06:26 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-04-20 16:06:51 PDT
Attachment 138184 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dana Jansens 2012-04-20 16:08:44 PDT
Created attachment 138185 [details]
Patch
Comment 5 James Robinson 2012-04-20 16:23:42 PDT
Comment on attachment 138185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138185&action=review

> Source/Platform/ChangeLog:3
> +        [chromium] Fix API for WebFilterOperations

this isn't a terribly useful title - maybe say something about what you're exporting?
Comment 6 Dana Jansens 2012-04-20 16:32:04 PDT
Created attachment 138192 [details]
Patch

true say, fixed.
Comment 7 Dana Jansens 2012-04-20 17:23:05 PDT
Comment on attachment 138192 [details]
Patch

Clearing flags on attachment: 138192

Committed r114807: <http://trac.webkit.org/changeset/114807>
Comment 8 Dana Jansens 2012-04-20 17:23:11 PDT
All reviewed patches have been landed.  Closing bug.