WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
Bug 84293
[Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2
https://bugs.webkit.org/show_bug.cgi?id=84293
Summary
[Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2
Mahesh Kulkarni
Reported
2012-04-18 15:49:38 PDT
Created
attachment 137790
[details]
Patch
r105988
implemented layoutTestController.setGeolocationPermission so we can unskip the -fast/dom/Geolocation/page-reload-cancel-permission-requests.html
Attachments
Patch
(665 bytes, patch)
2012-04-18 15:49 PDT
,
Mahesh Kulkarni
no flags
Details
Formatted Diff
Diff
Patch
(1.33 KB, patch)
2012-04-18 16:01 PDT
,
Mahesh Kulkarni
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mahesh Kulkarni
Comment 1
2012-04-18 16:01:17 PDT
Created
attachment 137794
[details]
Patch
Zoltan Arvai
Comment 2
2012-04-20 05:16:24 PDT
It seems the unskipped test fails with Qt5 on our x86-64 Linux Qt Release WebKit2 (Amazon EC2) and x86-32 Linux Qt Release WebKit2 bots: --- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt +++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/dom/Geolocation/page-reload-cancel-permission-requests-actual.txt @@ -1,10 +1,3 @@ -Tests that when a page is reloaded, the frame is properly detached from the Geolocation object to ensure that no permission requests are in progress. +CONSOLE MESSAGE: line 13: TypeError: 'undefined' is not a function (evaluating 'layoutTestController.numberOfPendingGeolocationPermissionRequests()') +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS numPendingRequests is 0 -PASS successfullyParsed is true - -TEST COMPLETE -
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r114688%20%281470%29/results.html
Jocelyn Turcotte
Comment 3
2014-02-03 03:20:36 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at
https://bugreports.qt-project.org
and add a link to this issue. See
http://qt-project.org/wiki/ReportingBugsInQt
for additional guidelines.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug