Bug 84280 - IndexedDB: Stub out IDBCursor.advance for landing
Summary: IndexedDB: Stub out IDBCursor.advance for landing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on:
Blocks: 84174
  Show dependency treegraph
 
Reported: 2012-04-18 14:29 PDT by Alec Flett
Modified: 2012-04-19 10:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.68 KB, patch)
2012-04-18 14:30 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Patch (3.55 KB, patch)
2012-04-18 15:25 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Patch (3.53 KB, patch)
2012-04-18 15:26 PDT, Alec Flett
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-04-18 14:29:24 PDT
IndexedDB: Stub out IDBCursor.advance for landing
Comment 1 Alec Flett 2012-04-18 14:30:30 PDT
Created attachment 137770 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-18 14:34:54 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Alec Flett 2012-04-18 15:25:04 PDT
Created attachment 137781 [details]
Patch
Comment 4 Alec Flett 2012-04-18 15:26:09 PDT
Created attachment 137782 [details]
Patch
Comment 5 Alec Flett 2012-04-18 15:26:42 PDT
ok, took a few tries, but this is pretty now.

dglazkov@ - r? cq?
Comment 6 Dimitri Glazkov (Google) 2012-04-19 09:17:13 PDT
Comment on attachment 137782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137782&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        Just a stub method so it can be implemented on chromium

Would love to have a period at the end of this sentence :)
Comment 7 WebKit Review Bot 2012-04-19 10:05:52 PDT
Comment on attachment 137782 [details]
Patch

Clearing flags on attachment: 137782

Committed r114647: <http://trac.webkit.org/changeset/114647>
Comment 8 WebKit Review Bot 2012-04-19 10:05:57 PDT
All reviewed patches have been landed.  Closing bug.