Bug 83956 - [WK2] Use ShareableSurface instead of ShareableBitmap in DrawingAreaImpl
: [WK2] Use ShareableSurface instead of ShareableBitmap in DrawingAreaImpl
Status: NEW
Product: WebKit
Classification: Unclassified
Component: WebKit2
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Igor Trindade Oliveira
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-13 16:04 PDT by Igor Trindade Oliveira
Modified: 2012-07-11 05:45 PDT (History)
12 users (show)

See Also:


Attachments
Patch (15.89 KB, patch)
2012-04-13 16:31 PDT, Igor Trindade Oliveira
no flags Details | Formatted Diff | Diff
Patch (21.38 KB, patch)
2012-04-16 09:30 PDT, Igor Trindade Oliveira
buildbot: commit‑queue-
Details | Formatted Diff | Diff
Patch (21.94 KB, patch)
2012-04-16 10:06 PDT, Igor Trindade Oliveira
buildbot: commit‑queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (6.33 MB, application/zip)
2012-04-16 13:06 PDT, WebKit Review Bot
no flags Details
Patch (24.34 KB, patch)
2012-04-16 19:26 PDT, Igor Trindade Oliveira
buildbot: commit‑queue-
Details | Formatted Diff | Diff
Patch (24.57 KB, patch)
2012-04-16 20:37 PDT, Igor Trindade Oliveira
buildbot: commit‑queue-
Details | Formatted Diff | Diff
Patch (24.57 KB, patch)
2012-04-16 21:36 PDT, Igor Trindade Oliveira
hausmann: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Trindade Oliveira 2012-04-13 16:04:39 PDT
GTK and EFL port have plans to use OpenGL instead of Image backend, as initial step in WebKit2 we should use ShareableSurface instead of ShareableBitmap, so we can use OpenGL surfaces.
Comment 1 Igor Trindade Oliveira 2012-04-13 16:31:49 PDT
Created attachment 137175 [details]
Patch

WIP patch.
Comment 2 Igor Trindade Oliveira 2012-04-16 09:30:25 PDT
Created attachment 137354 [details]
Patch

Proposed patch.
Comment 3 WebKit Review Bot 2012-04-16 09:32:32 PDT
Attachment 137354 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Shared/ShareableSurface.h:67:  The parameter name "hints" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2012-04-16 09:51:08 PDT
Comment on attachment 137354 [details]
Patch

Attachment 137354 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12416147
Comment 5 Igor Trindade Oliveira 2012-04-16 10:06:28 PDT
Created attachment 137359 [details]
Patch

Fix windows build.
Comment 6 WebKit Review Bot 2012-04-16 10:09:57 PDT
Attachment 137359 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Shared/ShareableSurface.h:67:  The parameter name "hints" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Build Bot 2012-04-16 10:20:48 PDT
Comment on attachment 137359 [details]
Patch

Attachment 137359 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12412438
Comment 8 WebKit Review Bot 2012-04-16 13:05:59 PDT
Comment on attachment 137359 [details]
Patch

Attachment 137359 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12414447

New failing tests:
fast/canvas/webgl/shader-precision-format.html
Comment 9 WebKit Review Bot 2012-04-16 13:06:11 PDT
Created attachment 137386 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 10 Igor Trindade Oliveira 2012-04-16 19:26:48 PDT
Created attachment 137459 [details]
Patch

Trying again.
Comment 11 Noam Rosenthal 2012-04-16 19:30:53 PDT
Comment on attachment 137459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137459&action=review

> Source/WebKit2/Shared/ShareableSurface.h:41
> +        SupportsGraphicsSurface = 0x01,
> +        None = 0x0

I'd rather if we put None first, and call it NoHints
Comment 12 Build Bot 2012-04-16 19:48:14 PDT
Comment on attachment 137459 [details]
Patch

Attachment 137459 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12414631
Comment 13 Igor Trindade Oliveira 2012-04-16 20:37:47 PDT
Created attachment 137471 [details]
Patch

Use NoHints instead of None.
Comment 14 Build Bot 2012-04-16 20:58:49 PDT
Comment on attachment 137471 [details]
Patch

Attachment 137471 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12416438
Comment 15 Igor Trindade Oliveira 2012-04-16 21:36:04 PDT
Created attachment 137474 [details]
Patch

it is becoming boring, trying again.
Comment 16 Simon Hausmann 2012-06-27 23:18:39 PDT
(In reply to comment #0)
> GTK and EFL port have plans to use OpenGL instead of Image backend, as initial step in WebKit2 we should use ShareableSurface instead of ShareableBitmap, so we can use OpenGL surfaces.

You say initial step, but are you actually going to end up with that design?

I mean, if you go through with this you're also going to have to change the backing stores to be surfaces, and you'll probably want to combine multiple updates into the same surface. And then you'll end up half-way re-implementing what exists already for the WK2 AC implementation.

So wouldn't it be simpler to leave the drawing area with its working approach of using shared memory and software rendering (and update incorporation) and instead focus on the WK2 AC implementation? Because I suspect in the end you're going to want to use that and remain in permanent state of AC.
Comment 17 Kenneth Rohde Christiansen 2012-06-27 23:22:22 PDT
(In reply to comment #16)
> (In reply to comment #0)
> > GTK and EFL port have plans to use OpenGL instead of Image backend, as initial step in WebKit2 we should use ShareableSurface instead of ShareableBitmap, so we can use OpenGL surfaces.
> 
> You say initial step, but are you actually going to end up with that design?
> 
> I mean, if you go through with this you're also going to have to change the backing stores to be surfaces, and you'll probably want to combine multiple updates into the same surface. And then you'll end up half-way re-implementing what exists already for the WK2 AC implementation.
> 
> So wouldn't it be simpler to leave the drawing area with its working approach of using shared memory and software rendering (and update incorporation) and instead focus on the WK2 AC implementation? Because I suspect in the end you're going to want to use that and remain in permanent state of AC.

I totally agree with that. That would be the right approach.
Comment 18 Simon Hausmann 2012-07-11 05:45:58 PDT
Comment on attachment 137474 [details]
Patch

I'm saying r- based on the lack of clarity about where this is going and why it is better than putting an effort into getting WK2 AC working for the ports in question.