Bug 83532 - run-perf-tests fail intermittently with an exception
: run-perf-tests fail intermittently with an exception
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 77037
  Show dependency treegraph
 
Reported: 2012-04-09 18:12 PST by
Modified: 2012-04-23 16:13 PST (History)


Attachments
Patch (3.73 KB, patch)
2012-04-23 15:17 PST, Dirk Pranke
rniwa: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-09 18:12:47 PST
Lion Release (Perf) fails intermittently with the following error:

http://build.webkit.org/builders/Lion%20Release%20%28Perf%29/builds/2080/steps/perf-test/logs/stdio

Traceback (most recent call last):
  File "./Tools/Scripts/run-perf-tests", line 41, in <module>
    sys.exit(PerfTestsRunner().run())
  File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 141, in run
    unexpected = self._run_tests_set(sorted(list(tests)), self._port)
  File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 234, in _run_tests_set
    if self._run_single_test(test, driver, is_chromium_style):
  File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 317, in _run_single_test
    output = driver.run_test(DriverInput(test, self._options.time_out_ms, None, False))
  File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 219, in run_test
    return self._running_drivers[cmd_line_key].run_test(driver_input)
  File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 571, in run_test
    crash_log = self._port._get_crash_log(self._crashed_process_name, self._crashed_pid, text, self.error_from_test)
  File "/Volumes/Data/slave/lion-release-perf-tests/build/Tools/Scripts/webkitpy/layout_tests/port/mac.py", line 188, in _get_crash_log
    deadline = now + 5 * int(self.get_option('child_processes'))
TypeError: int() argument must be a string or a number, not 'NoneType'
program finished with exit code 1
elapsedTime=1367.658724

Maybe this is related to mac ports' tests intermittently fail?
------- Comment #1 From 2012-04-09 18:19:34 PST -------
i think this is probably an unrelated bug; I'm guessing it happens every time you get a crash, but you probably don't see crashes very often in the perf tests?
------- Comment #2 From 2012-04-09 18:28:04 PST -------
(In reply to comment #1)
> i think this is probably an unrelated bug; I'm guessing it happens every time you get a crash, but you probably don't see crashes very often in the perf tests?

Right, we rarely add new perf tests and they aren't supposed to crash. In fact, perf bots turn red if any one of them crash.
------- Comment #3 From 2012-04-23 15:17:09 PST -------
Created an attachment (id=138433) [details]
Patch
------- Comment #4 From 2012-04-23 15:48:54 PST -------
(From update of attachment 138433 [details])
rs=me.
------- Comment #5 From 2012-04-23 16:13:30 PST -------
Committed r114960: <http://trac.webkit.org/changeset/114960>