Bug 83488 - Fixed ordering of deleting CCInputHandler and LayerTreeHostImpl in layerTreeHostClosedOnImplThread
Summary: Fixed ordering of deleting CCInputHandler and LayerTreeHostImpl in layerTreeH...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-09 11:02 PDT by Min Qin
Modified: 2012-04-09 21:05 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.85 KB, patch)
2012-04-09 11:15 PDT, Min Qin
no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2012-04-09 16:28 PDT, Min Qin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Min Qin 2012-04-09 11:02:55 PDT
Fixed ordering of deleting CCInputHandler and LayerTreeHostImpl in layerTreeHostClosedOnImplThread
Comment 1 Min Qin 2012-04-09 11:15:24 PDT
Created attachment 136271 [details]
Patch
Comment 2 James Robinson 2012-04-09 11:18:36 PDT
Comment on attachment 136271 [details]
Patch

R=me
Comment 3 WebKit Review Bot 2012-04-09 14:42:32 PDT
Comment on attachment 136271 [details]
Patch

Rejecting attachment 136271 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12368393
Comment 4 Min Qin 2012-04-09 16:28:37 PDT
Created attachment 136333 [details]
Patch
Comment 5 Min Qin 2012-04-09 16:29:56 PDT
Comment on attachment 136333 [details]
Patch

Hi, James, would you please do it again. Seems webkit is not happy with the missing "Reviewed by "
Comment 6 James Robinson 2012-04-09 16:48:57 PDT
Comment on attachment 136333 [details]
Patch

Yup, it's picky like that.
Comment 7 WebKit Review Bot 2012-04-09 21:05:52 PDT
Comment on attachment 136333 [details]
Patch

Clearing flags on attachment: 136333

Committed r113673: <http://trac.webkit.org/changeset/113673>
Comment 8 WebKit Review Bot 2012-04-09 21:05:56 PDT
All reviewed patches have been landed.  Closing bug.