WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 83327
Web Inspector: CodeGeneratorInspector.py: stop accepting raw InspectorObject in generated setters
https://bugs.webkit.org/show_bug.cgi?id=83327
Summary
Web Inspector: CodeGeneratorInspector.py: stop accepting raw InspectorObject ...
Peter Rybin
Reported
2012-04-05 16:33:37 PDT
Currently all types in InspectorTypeBuilder accept raw InspectorObject or String instead of dedicated struct type and enum type correspondingly. Disable this and change client C++ code accordingly.
Attachments
Patch
(43.87 KB, patch)
2012-04-05 16:44 PDT
,
Peter Rybin
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Peter Rybin
Comment 1
2012-04-05 16:44:07 PDT
Created
attachment 135935
[details]
Patch
Pavel Feldman
Comment 2
2012-04-06 08:14:23 PDT
Comment on
attachment 135935
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=135935&action=review
> Source/WebCore/ChangeLog:3 > + Web Inspector: CodeGeneratorInspector.py: stop accept raw InspectorObject in generated setters
stop accepting ?
> Source/WebCore/ChangeLog:10 > + All client code is switched from InspectorObject's and String's to generated types where
Whole / entire ?
Pavel Feldman
Comment 3
2012-04-06 08:23:41 PDT
Committed
r113438
: <
http://trac.webkit.org/changeset/113438
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug