Bug 83327 - Web Inspector: CodeGeneratorInspector.py: stop accepting raw InspectorObject in generated setters
Summary: Web Inspector: CodeGeneratorInspector.py: stop accepting raw InspectorObject ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 72861
  Show dependency tree / graph
 
Reported: 2012-04-05 16:33 PDT by Peter Rybin
Modified: 2012-04-06 08:23 PDT (History)
10 users (show)

See Also:

Attachments
Patch (43.87 KB, patch)
2012-04-05 16:44 PDT, Peter Rybin 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2012-04-05 16:33:37 PDT 
Currently all types in InspectorTypeBuilder accept raw InspectorObject or String instead of dedicated struct type and enum type correspondingly.
Disable this and change client C++ code accordingly.
Comment 1 Peter Rybin 2012-04-05 16:44:07 PDT 
Created attachment 135935 [details]
Patch
Comment 2 Pavel Feldman 2012-04-06 08:14:23 PDT 
Comment on attachment 135935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135935&action=review

> Source/WebCore/ChangeLog:3
> +        Web Inspector: CodeGeneratorInspector.py: stop accept raw InspectorObject in generated setters

stop accepting ?

> Source/WebCore/ChangeLog:10
> +        All client code is switched from InspectorObject's and String's to generated types where

Whole / entire ?
Comment 3 Pavel Feldman 2012-04-06 08:23:41 PDT 
Committed r113438: <http://trac.webkit.org/changeset/113438>