Bug 83314 - [BlackBerry] Update the InstrumentedPlatformCanvas after rebasing Skia
Summary: [BlackBerry] Update the InstrumentedPlatformCanvas after rebasing Skia
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-05 14:28 PDT by Arvid Nilsson
Modified: 2012-04-05 16:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2012-04-05 14:58 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2012-04-05 15:11 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-04-05 14:28:20 PDT 
One new virtual method was added to SkCanvas, and it's probably not called by GraphicsContextSkia, but add it just to be sure.
Comment 1 Arvid Nilsson 2012-04-05 14:58:49 PDT 
Created attachment 135910 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-05 15:03:22 PDT 
Attachment 135910 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/blackberry/InstrumentedPlatformCanvas.h:203:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Arvid Nilsson 2012-04-05 15:11:05 PDT 
Created attachment 135917 [details]
Patch
Comment 4 WebKit Review Bot 2012-04-05 16:00:31 PDT 
Comment on attachment 135917 [details]
Patch

Clearing flags on attachment: 135917

Committed r113390: <http://trac.webkit.org/changeset/113390>
Comment 5 WebKit Review Bot 2012-04-05 16:00:35 PDT 
All reviewed patches have been landed.  Closing bug.