WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83314
[BlackBerry] Update the InstrumentedPlatformCanvas after rebasing Skia
https://bugs.webkit.org/show_bug.cgi?id=83314
Summary
[BlackBerry] Update the InstrumentedPlatformCanvas after rebasing Skia
Arvid Nilsson
Reported
2012-04-05 14:28:20 PDT
One new virtual method was added to SkCanvas, and it's probably not called by GraphicsContextSkia, but add it just to be sure.
Attachments
Patch
(1.88 KB, patch)
2012-04-05 14:58 PDT
,
Arvid Nilsson
no flags
Details
Formatted Diff
Diff
Patch
(1.87 KB, patch)
2012-04-05 15:11 PDT
,
Arvid Nilsson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Arvid Nilsson
Comment 1
2012-04-05 14:58:49 PDT
Created
attachment 135910
[details]
Patch
WebKit Review Bot
Comment 2
2012-04-05 15:03:22 PDT
Attachment 135910
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/blackberry/InstrumentedPlatformCanvas.h:203: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Arvid Nilsson
Comment 3
2012-04-05 15:11:05 PDT
Created
attachment 135917
[details]
Patch
WebKit Review Bot
Comment 4
2012-04-05 16:00:31 PDT
Comment on
attachment 135917
[details]
Patch Clearing flags on attachment: 135917 Committed
r113390
: <
http://trac.webkit.org/changeset/113390
>
WebKit Review Bot
Comment 5
2012-04-05 16:00:35 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug