Bug 83278 - Update LayoutUnit usage in Editor and Frame
Summary: Update LayoutUnit usage in Editor and Frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-05 07:31 PDT by Levi Weintraub
Modified: 2012-04-06 11:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.33 KB, patch)
2012-04-05 07:41 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Patch (6.16 KB, patch)
2012-04-05 09:14 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-04-05 07:31:04 PDT 
Both have functions that are taking LayoutUnit coordinates that represent screen coordinates. These should be Ints.
Comment 1 Levi Weintraub 2012-04-05 07:41:44 PDT 
Created attachment 135822 [details]
Patch
Comment 2 Build Bot 2012-04-05 08:08:32 PDT 
Comment on attachment 135822 [details]
Patch

Attachment 135822 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12340349
Comment 3 Build Bot 2012-04-05 08:21:18 PDT 
Comment on attachment 135822 [details]
Patch

Attachment 135822 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12264329
Comment 4 Levi Weintraub 2012-04-05 09:14:27 PDT 
Created attachment 135837 [details]
Patch
Comment 5 Levi Weintraub 2012-04-06 08:59:30 PDT 
Friendly neighborhood "ping" :)
Comment 6 WebKit Review Bot 2012-04-06 11:35:06 PDT 
Comment on attachment 135837 [details]
Patch

Clearing flags on attachment: 135837

Committed r113466: <http://trac.webkit.org/changeset/113466>
Comment 7 WebKit Review Bot 2012-04-06 11:35:11 PDT 
All reviewed patches have been landed.  Closing bug.