Bug 83228 - WaveTable::waveDataForFundamentalFrequency() should properly interpret negative frequency
Summary: WaveTable::waveDataForFundamentalFrequency() should properly interpret negati...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-04 15:43 PDT by Chris Rogers
Modified: 2012-04-04 17:15 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2012-04-04 15:44 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2012-04-04 15:43:17 PDT
WaveTable::waveDataForFundamentalFrequency() should properly interpret negative frequency
Comment 1 Chris Rogers 2012-04-04 15:44:21 PDT
Created attachment 135703 [details]
Patch
Comment 2 Kenneth Russell 2012-04-04 15:48:13 PDT
Comment on attachment 135703 [details]
Patch

Seems fine. Any tests possible? r=me
Comment 3 Chris Rogers 2012-04-04 16:07:33 PDT
(In reply to comment #2)
> (From update of attachment 135703 [details])
> Seems fine. Any tests possible? r=me

Yes, the tests will come when it becomes possible to modulate an AudioParam with an audio-rate signal.
Comment 4 WebKit Review Bot 2012-04-04 17:14:58 PDT
Comment on attachment 135703 [details]
Patch

Clearing flags on attachment: 135703

Committed r113268: <http://trac.webkit.org/changeset/113268>
Comment 5 WebKit Review Bot 2012-04-04 17:15:02 PDT
All reviewed patches have been landed.  Closing bug.