Bug 83192 - [Chromium, DRT] Bounds check indices on gamepadController
Summary: [Chromium, DRT] Bounds check indices on gamepadController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Scott Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-04 12:38 PDT by Scott Graham
Modified: 2012-04-04 18:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.00 KB, patch)
2012-04-04 12:39 PDT, Scott Graham 		no flags Details | Formatted Diff | Diff
fix warnings (4.12 KB, patch)
2012-04-04 13:27 PDT, Scott Graham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Graham 2012-04-04 12:38:36 PDT 
[Chromium, DRT] Bounds check indices on gamepadController
Comment 1 Scott Graham 2012-04-04 12:39:58 PDT 
Created attachment 135654 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-04 13:24:22 PDT 
Comment on attachment 135654 [details]
Patch

Attachment 135654 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12330034
Comment 3 Scott Graham 2012-04-04 13:27:56 PDT 
Created attachment 135664 [details]
fix warnings
Comment 4 Kent Tamura 2012-04-04 18:06:54 PDT 
Comment on attachment 135664 [details]
fix warnings

ok
Ideally we should throw exceptions in such case, but it seems there are no ways to do it.
Comment 5 WebKit Review Bot 2012-04-04 18:57:35 PDT 
Comment on attachment 135664 [details]
fix warnings

Clearing flags on attachment: 135664

Committed r113274: <http://trac.webkit.org/changeset/113274>
Comment 6 WebKit Review Bot 2012-04-04 18:57:39 PDT 
All reviewed patches have been landed.  Closing bug.