Bug 83154 - Correct LayoutUnit usage in style functions adjustRectForShadow and getRoundedBorderFor
Summary: Correct LayoutUnit usage in style functions adjustRectForShadow and getRounde...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-04 06:15 PDT by Levi Weintraub
Modified: 2012-04-09 11:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2012-04-04 06:28 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Patch for landing (2.69 KB, patch)
2012-04-09 09:56 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-04-04 06:15:18 PDT 
adjustRectForShadow needs to adjust a LayoutRect since it's used to adjust repaint rects and such, while getRoundedBorderFor returns a pixel snapped RoundedRect.
Comment 1 Levi Weintraub 2012-04-04 06:28:38 PDT 
Created attachment 135578 [details]
Patch
Comment 2 Levi Weintraub 2012-04-06 10:14:02 PDT 
Comment on attachment 135578 [details]
Patch

Thanks!
Comment 3 WebKit Review Bot 2012-04-06 10:30:41 PDT 
Comment on attachment 135578 [details]
Patch

Rejecting attachment 135578 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Core/rendering/style/ShadowData.cpp
Hunk #1 FAILED at 68.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/ShadowData.cpp.rej
patching file Source/WebCore/rendering/style/ShadowData.h
Hunk #1 FAILED at 79.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/ShadowData.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Julien Cha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12264970
Comment 4 Levi Weintraub 2012-04-09 09:56:26 PDT 
Created attachment 136244 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-04-09 11:10:17 PDT 
Comment on attachment 136244 [details]
Patch for landing

Clearing flags on attachment: 136244

Committed r113594: <http://trac.webkit.org/changeset/113594>
Comment 6 WebKit Review Bot 2012-04-09 11:10:22 PDT 
All reviewed patches have been landed.  Closing bug.