Bug 83134 - Web Inspector: front-end should accept raw web socket address for the remote connection.
: Web Inspector: front-end should accept raw web socket address for the remote ...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Pavel Feldman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-04 02:52 PDT by Pavel Feldman
Modified: 2012-04-04 04:19 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.19 KB, patch)
2012-04-04 02:56 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (2.19 KB, patch)
2012-04-04 03:07 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-04-04 02:52:57 PDT
Migrated from the /devtools/page web socket schema to the generic one where page address can be specified as index.html?ws=localhost:9222/page1
Comment 1 Pavel Feldman 2012-04-04 02:56:10 PDT
Created attachment 135539 [details]
Patch
Comment 2 Yury Semikhatsky 2012-04-04 03:05:45 PDT
Comment on attachment 135539 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135539&action=review

> Source/WebCore/inspector/front-end/inspector.js:351
> +    if ("ws" WebInspector.queryParamsObject)

"ws" in ?
Comment 3 Pavel Feldman 2012-04-04 03:07:20 PDT
Created attachment 135543 [details]
Patch
Comment 4 Pavel Feldman 2012-04-04 04:19:58 PDT
Committed r113167: <http://trac.webkit.org/changeset/113167>