Bug 83115 - Don't parse "show" and "hide" as valid values for display property.
Summary: Don't parse "show" and "hide" as valid values for display property.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-03 21:04 PDT by Luke Macpherson
Modified: 2012-04-04 06:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2012-04-03 21:05 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch for landing (1.39 KB, patch)
2012-04-03 21:27 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch for landing (2.24 KB, patch)
2012-04-03 21:29 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-04-03 21:04:16 PDT 
Don't parse "show" and "hide" as valid values for display property.
Comment 1 Luke Macpherson 2012-04-03 21:05:07 PDT 
Created attachment 135506 [details]
Patch
Comment 2 Adam Barth 2012-04-03 21:17:00 PDT 
Comment on attachment 135506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135506&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests.

I can haz test?
Comment 3 Adam Barth 2012-04-03 21:20:46 PDT 
Comment on attachment 135506 [details]
Patch

This patch is obviously correct, but it seems like we could write some kind of test, even if the test wouldn't do anything when CSS_GRID_LAYOUT was enabled.  If I were writing this patch, I would include that test, but I can understand why you didn't.
Comment 4 Luke Macpherson 2012-04-03 21:27:53 PDT 
Created attachment 135508 [details]
Patch for landing
Comment 5 Luke Macpherson 2012-04-03 21:29:29 PDT 
Created attachment 135509 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-04-03 22:07:34 PDT 
Comment on attachment 135509 [details]
Patch for landing

Clearing flags on attachment: 135509

Committed r113139: <http://trac.webkit.org/changeset/113139>
Comment 7 WebKit Review Bot 2012-04-03 22:07:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 noel gordon 2012-04-04 06:17:22 PDT 
ChangeLog: "No new tests?"  Could we amend the ChangeLog please.