Bug 83042 - WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
Summary: WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-03 09:48 PDT by Jocelyn Turcotte
Modified: 2012-04-09 08:32 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.49 KB, patch)
2012-04-03 09:57 PDT, Jocelyn Turcotte
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2012-04-03 09:48:51 PDT
WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
Comment 1 Jocelyn Turcotte 2012-04-03 09:57:28 PDT
Created attachment 135348 [details]
Patch
Comment 2 Kent Tamura 2012-04-03 20:10:01 PDT
Comment on attachment 135348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135348&action=review

> Source/WebCore/Modules/websockets/WebSocketFrame.cpp:157
> +    char& firstByte = frameData.at(0);
> +    char& secondByte = frameData.at(1);
> +    firstByte = (final ? finalBit : 0) | (compress ? compressBit : 0) | opCode;

The variable firstByte looks unnecessary.
  frameData.at(0) = (final ? ...
Comment 3 Jocelyn Turcotte 2012-04-09 08:31:35 PDT
Committed r113580: <http://trac.webkit.org/changeset/113580>
Comment 4 Jocelyn Turcotte 2012-04-09 08:32:51 PDT
Thanks!