RESOLVED FIXED Bug 83042
WebSocketServer: Honour WebSocketFrame::masked in makeFrameData 
https://bugs.webkit.org/show_bug.cgi?id=83042
Summary WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
Jocelyn Turcotte
Reported 2012-04-03 09:48:51 PDT
WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
Attachments
Patch (4.49 KB, patch)
2012-04-03 09:57 PDT, Jocelyn Turcotte 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2012-04-03 09:57:28 PDT
Created attachment 135348 [details] Patch
Kent Tamura
Comment 2 2012-04-03 20:10:01 PDT
Comment on attachment 135348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135348&action=review > Source/WebCore/Modules/websockets/WebSocketFrame.cpp:157 > + char& firstByte = frameData.at(0); > + char& secondByte = frameData.at(1); > + firstByte = (final ? finalBit : 0) | (compress ? compressBit : 0) | opCode; The variable firstByte looks unnecessary. frameData.at(0) = (final ? ...
Jocelyn Turcotte
Comment 3 2012-04-09 08:31:35 PDT
Committed r113580: <http://trac.webkit.org/changeset/113580>
Jocelyn Turcotte
Comment 4 2012-04-09 08:32:51 PDT
Thanks!
Note You need to log in before you can comment on or make changes to this bug.