Bug 82941 - We should use CSSPropertyID rather than integers when manipulating CSS property ids.
Summary: We should use CSSPropertyID rather than integers when manipulating CSS proper...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 13:38 PDT by Alexis Menard (darktears)
Modified: 2012-04-04 06:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (22.23 KB, patch)
2012-04-02 13:56 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-04-02 13:38:00 PDT 
We should use CSSPropertyID rather than integers when manipulating CSS property ids.
Comment 1 Alexis Menard (darktears) 2012-04-02 13:56:26 PDT 
Created attachment 135177 [details]
Patch
Comment 2 Alexis Menard (darktears) 2012-04-02 13:57:35 PDT 
(In reply to comment #1)
> Created an attachment (id=135177) [details]
> Patch

It's quite a big change at the end, I'm willing to it but I want to make sure people agree that it will make the code nicer.
Comment 3 Alexis Menard (darktears) 2012-04-02 13:58:05 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=135177) [details] [details]
> > Patch
> 
> It's quite a big change at the end, I'm willing to it but I want to make sure people agree that it will make the code nicer.

big change I mean because there will be more patches.
Comment 4 WebKit Review Bot 2012-04-02 15:30:22 PDT 
Comment on attachment 135177 [details]
Patch

Clearing flags on attachment: 135177

Committed r112952: <http://trac.webkit.org/changeset/112952>
Comment 5 WebKit Review Bot 2012-04-02 15:30:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexis Menard (darktears) 2012-04-04 06:56:16 PDT 
(In reply to comment #5)
> All reviewed patches have been landed.  Closing bug.

https://bugs.webkit.org/show_bug.cgi?id=83151 fixes variable names removed too aggressively in some .h files.