Bug 82808 - Clean up MediaQueryEvaluator construction in CSSStyleSelector (and remove out of date comments)
Summary: Clean up MediaQueryEvaluator construction in CSSStyleSelector (and remove out...
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 45950
  Show dependency treegraph
 
Reported: 2012-03-30 17:24 PDT by Eric Seidel (no email)
Modified: 2012-04-01 17:45 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2012-03-30 17:24 PDT, Eric Seidel (no email)
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-02 (7.03 MB, application/zip)
2012-03-30 21:06 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-03-30 17:24:13 PDT
Clean up MediaQueryEvaluator construction in CSSStyleSelector (and remove out of date comments)
Comment 1 Eric Seidel (no email) 2012-03-30 17:24:39 PDT
Created attachment 134917 [details]
Patch
Comment 2 Adam Barth 2012-03-30 17:36:22 PDT
Comment on attachment 134917 [details]
Patch

I guess this depends on whether styleForElement needs m_medium, but it seems like if it does, it's going to get the wrong one with the old code...
Comment 3 Eric Seidel (no email) 2012-03-30 20:26:31 PDT
Comment on attachment 134917 [details]
Patch

Should apply now.
Comment 4 WebKit Review Bot 2012-03-30 21:06:41 PDT
Comment on attachment 134917 [details]
Patch

Rejecting attachment 134917 [details] from commit-queue.

New failing tests:
http/tests/appcache/deferred-events-delete-while-raising-timer.html
animations/3d/transform-origin-vs-functions.html
accessibility/aria-checkbox-checked.html
http/tests/appcache/access-via-redirect.php
animations/animation-css-rule-types.html
animations/3d/matrix-transform-type-animation.html
animations/animation-border-overflow.html
http/tests/appcache/cyrillic-uri.html
animations/animation-controller-drt-api.html
http/tests/appcache/credential-url.html
http/tests/appcache/crash-when-navigating-away-then-back.html
accessibility/anonymous-render-block-in-continuation-causes-crash.html
accessibility/adjacent-continuations-cause-assertion-failure.html
animations/additive-transform-animations.html
animations/3d/change-transform-in-end-event.html
animations/3d/replace-filling-transform.html
animations/3d/state-at-end-event-transform.html
accessibility/anchor-linked-anonymous-block-crash.html
accessibility/aria-checkbox-sends-notification.html
animations/animation-add-events-in-handler.html
Full output: http://queues.webkit.org/results/12262579
Comment 5 WebKit Review Bot 2012-03-30 21:06:46 PDT
Created attachment 134940 [details]
Archive of layout-test-results from ec2-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick