Bug 82657 - [Chromium] Move ResourceHandle to WebCore/platform/network/chromium
Summary: [Chromium] Move ResourceHandle to WebCore/platform/network/chromium
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2012-03-29 14:19 PDT by Adam Barth
Modified: 2012-03-31 01:34 PDT (History)
2 users (show)

See Also:

Patch (49.21 KB, patch)
2012-03-29 14:22 PDT, Adam Barth
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-03-29 14:19:54 PDT
[Chromium] Move ResourceHandle to WebCore/platform/network/chromium
Comment 1 Adam Barth 2012-03-29 14:22:22 PDT
Created attachment 134665 [details]
Comment 2 WebKit Review Bot 2012-03-29 14:30:12 PDT
Attachment 134665 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/chromium/ResourceHandle.cpp:247:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/network/chromium/ResourceHandle.cpp:279:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/platform/network/chromium/ResourceHandle.cpp:283:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 3 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 James Robinson 2012-03-29 14:32:10 PDT
Comment on attachment 134665 [details]

Comment 4 Adam Barth 2012-03-29 14:44:35 PDT
Committed r112579: <http://trac.webkit.org/changeset/112579>
Comment 5 Adam Barth 2012-03-29 18:36:17 PDT
Reverted r112579 for reason:

Does not compile in Windows component build

Committed r112633: <http://trac.webkit.org/changeset/112633>